fix query select for order number #2713
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ojhaujjwal
force-pushed
the
hotfix-ordernumber-query
branch
from
355ac50
to
12e867a
Compare
|
@ojhaujjwal Can you show us the trace of the exception, plz ? |
|
@Arn0d Even in case of exception IMO this change is must have ;) Counting on all table columns is evil 🙈 |
|
👍 |
arnolanglade
added a commit
that referenced
this pull request
May 5, 2015
fix query select for order number
|
Thank you Ujjwal. |
|
+1 |
|
@Arn0d It's my pleasure! :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to override the order number generator. But, I got an exception saying something like Parse error, unexpected * etc. I changed it to this and it worked.