Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ContentBundle] Show all available filters in imagine block form #2716

Merged
merged 1 commit into from May 6, 2015
Merged

[ContentBundle] Show all available filters in imagine block form #2716

merged 1 commit into from May 6, 2015

Conversation

aramalipoor
Copy link
Contributor

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets -
License MIT
Doc PR -

@aramalipoor aramalipoor changed the title [ContentBundle] Show all available filters in ImagineBlockType form [ContentBundle] Show all available filters in imagine block form May 6, 2015
pjedrzejewski pushed a commit that referenced this pull request May 6, 2015
Merge pull request #2716 from vendora/fix/content-bundle-imagine-type
f31de5d 
[ContentBundle] Show all available filters in imagine block form
@pjedrzejewski pjedrzejewski merged commit f31de5d into Sylius:master May 6, 2015
@pjedrzejewski
Copy link
Member

Perfect, thanks man! 👍

@aramalipoor aramalipoor deleted the fix/content-bundle-imagine-type branch May 6, 2015 08:14
@psyray
Copy link
Contributor

psyray commented May 18, 2015

Could you please add the translations too ?
translation-missing

@psyray
Copy link
Contributor

psyray commented May 18, 2015

In fact you point out the translation to the wrong existing one.
sylius.form.imagine_block.filter.* instead of sylius.form.imagine_block.*.
Look at the ContentBundle/Resources/translations/messages.en.yml file.
And you should add the missing ones (sylius small...).

Thanks

@aramalipoor aramalipoor restored the fix/content-bundle-imagine-type branch May 18, 2015 10:30
@aramalipoor aramalipoor deleted the fix/content-bundle-imagine-type branch May 18, 2015 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aramalipoor @pjedrzejewski @psyray