Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi channel #2752

Merged
merged 39 commits into from
May 21, 2015
Merged

Multi channel #2752

merged 39 commits into from
May 21, 2015

Conversation

michalmarcinkowski
Copy link
Contributor

Rebased PR opened by @loevstroem (#2395). Ready to merge.

isset($data['shipping']) ? $data['shipping'] : null,
isset($data['payments']) ? $data['payments'] : null,
false
);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

identation

@arnolanglade arnolanglade added Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). RFC Discussions about potential changes or new features. labels May 21, 2015
Paweł Jędrzejewski added 6 commits May 21, 2015 10:49
Conflicts:
	phpspec.yml
	src/Sylius/Bundle/CoreBundle/DependencyInjection/SyliusCoreExtension.php
	src/Sylius/Bundle/CoreBundle/Resources/config/app/sylius.yml
	src/Sylius/Bundle/CurrencyBundle/spec/Sylius/Bundle/CurrencyBundle/Templating/Helper/CurrencyHelperSpec.php
	src/Sylius/Bundle/MoneyBundle/spec/Sylius/Bundle/MoneyBundle/Templating/Helper/MoneyHelperSpec.php
(cherry picked from commit a35b980)
(cherry picked from commit ca3a9b3)
(cherry picked from commit a37c9b1)
(cherry picked from commit 4f58bb9)
(cherry picked from commit c103d8f)
Paweł Jędrzejewski and others added 2 commits May 21, 2015 14:18
@koemeet
Copy link
Contributor

koemeet commented May 21, 2015

Quick question. Is it possible to seperate users per channel/store. I am planning on using channels to have multiple seperate webshops. So the users need to have a reference to a channel. Also if not supported yet, is it preferable to have this? I could add this as a pr once this one is merged.

Paweł Jędrzejewski and others added 2 commits May 21, 2015 22:29
pjedrzejewski pushed a commit that referenced this pull request May 21, 2015
@pjedrzejewski pjedrzejewski merged commit 77e0ff1 into Sylius:master May 21, 2015
@pjedrzejewski
Copy link
Member

Wooohoo!!! :) Thank you @loevstroem and @michalmarcinkowski!

@arnolanglade
Copy link
Contributor

✌️

@kayue
Copy link
Contributor

kayue commented May 22, 2015

Thank you @michalmarcinkowski :)

@steffenbrem You probably will end up having conflict with username / email address, because they must be unique in the database right now. I guess one quick work around is to enable Facebook connect ONLY so user won't even able to tell the difference whether they are registered or not.

@michalmarcinkowski michalmarcinkowski deleted the multi-channel branch March 7, 2016 23:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). RFC Discussions about potential changes or new features.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants