Fixed bug in payment flow #2758
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I noticed that if you are using CreditCard for payment and if you change your mind on page where you need to enter your credit card, jump back to payment methods and pick something else for example offline that there is bug and you cannot complete payment. This PR fix it
|
@makasim WDYT? |
| @@ -71,6 +71,8 @@ public function createOrderPayment(GenericEvent $event) | |||
| { | |||
| if (false === $this->getOrder($event)->getLastPayment()) { | |||
| $this->paymentProcessor->createPayment($this->getOrder($event)); | |||
| } else { | |||
| $this->getOrder($event)->getLastPayment()->setDetails(array()); | |||
| } | |||
There was a problem hiding this comment.
I do not think we have to change the last payment but rather create a new one so an admin can see the whole history, like user selected one payment but than changed his mind and selected another one
There was a problem hiding this comment.
then just remove if and always create new?
There was a problem hiding this comment.
@antonioperic yeap sounds better
pjedrzejewski
pushed a commit
that referenced
this pull request
May 26, 2015
Fixed bug in payment flow
|
Thank you Antonio! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that if you are using CreditCard for payment and if you change your mind on page where you need to enter your credit card, jump back to payment methods and pick something else for example offline that there is bug and you cannot complete payment. This PR fix it