Fixes collection name deciding script causing item overwriting #2788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Getting an item's name from collection's children count is unreliable and caused data loss when items got deleted and shuffled around or when there was some other element in the collection element. This fixes that issue by actually checking if the items are present.
pjedrzejewski
pushed a commit
that referenced
this pull request
May 29, 2015
Fixes collection name deciding script causing item overwriting
|
Really nice, thank you very much @Amunak! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Getting an item's name from collection's children count is unreliable and caused data loss when items got deleted and shuffled around or when there were other child elements in the collection element. This fixes that issue by actually checking if the items are present.
Inspired by Bootstrap's solution.
It's still very fast even with thousands of items in a collection.