[UserBundle] CS fixes and missing specs #2824
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
arnolanglade
commented
Jun 8, 2015
arnolanglade
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | refactoring |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets | no |
| License | MIT |
| Doc PR | - |
arnolanglade
changed the title
arnolanglade
changed the title
| // $userManager->flush()->shouldBeCalled(); | ||
| // | ||
| // $this->loadUserByOAuthUserResponse($response)->shouldReturn($user); | ||
| // } |
There was a problem hiding this comment.
Why is it all commented out?
There was a problem hiding this comment.
because I failed !
|
@Arn0d The build seems to be failing with a missing class error. |
| @@ -27,4 +27,4 @@ assetic: | |||
|
|
|||
| doctrine: | |||
| dbal: | |||
| dbname: %sylius.database.name%_dev | |||
| dbname: %sylius.database.name%_test | |||
|
@pjedrzejewski I will have a look at midday. |
arnolanglade
force-pushed
the
user_spec
branch
3 times, most recently
from
ba4b74f
to
2a595f0
Compare
|
@pjedrzejewski green with the VariationBundle fixes |
pjedrzejewski
pushed a commit
that referenced
this pull request
Jun 10, 2015
[UserBundle] CS fixes and missing specs
|
Thank you Arnaud! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.