Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updates related to sales PR for orders #284

Closed
wants to merge 1 commit into from

Conversation

cordoval
Copy link
Contributor

@pjedrzejewski
Copy link
Member

I think this is wrong, the indicator of order completeness is the completedAt timestamp, not the presence / absence of the number...

@winzou
Copy link
Contributor

winzou commented Aug 29, 2013

Actually it should be its state!

@cordoval
Copy link
Contributor Author

@winzou may be more right, but it can't stay like this, @pjedrzejewski so i will update this PR with it

@pjedrzejewski
Copy link
Member

Closing this as we have to look down at all states handling and standardize them.

pamil pushed a commit to pamil/Sylius that referenced this pull request Mar 21, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants