[PayumBundle] Make offline payum capture action to be public

[aramalipoor]

No description provided.

[makasim]

What is the reason to have it public? FYI: The payum's action is not designed to be used outside of Gateway.

[aramalipoor]

@makasim Maybe I'm missing something, this is my config.yml:

payum:
    storages:
        Sylius\Component\Core\Model\Order: { doctrine: orm }
        Sylius\Component\Core\Model\Payment: { doctrine: orm }

    security:
        token_storage:
            Sylius\Bundle\PayumBundle\Model\PaymentSecurityToken: { doctrine: orm }

    dynamic_payments:
        config_storage:
            Sylius\Bundle\PayumBundle\Model\PaymentConfig: { doctrine: orm }

    payments:
        offline:
            offline:
                actions:
                    - sylius.payum.offline.action.capture_payment

I'm using sylius core in my project and with this configuration I get a "service not found" error for this action.

What do you think I'm missing?!

[makasim]

Yes, you are right. The gateways are created in runtime so the actions has to be public.

@pjedrzejewski good to merge

[pjedrzejewski]

Thank you Aram and Maksim! 👍

[aramalipoor]

👍 Thank you Makasim and Paweł ;)