[TaxationBundle] DelegatingCalculator use the ServiceRegistry #2897
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnolanglade
changed the title
| <service id="sylius.form.type.tax_calculator_choice" class="%sylius.form.type.tax_calculator_choice.class%"> | ||
| <argument>%sylius.tax_calculators%</argument> | ||
| <tag name="form.type" alias="sylius_tax_calculator_choice" /> | ||
| </service> | ||
|
|
||
| <service id="sylius.tax_calculator" class="%sylius.tax_calculator.class%" /> | ||
| <service id="sylius.tax_calculator" class="%sylius.tax_calculator.class%"> |
There was a problem hiding this comment.
Isn't it better to use sylius.registry.tax_calculator ?
arnolanglade
force-pushed
the
taxation_registry
branch
from
d5ae365
to
96d1795
Compare
arnolanglade
changed the title
|
@pjedrzejewski @aramalipoor updated ! |
arnolanglade
force-pushed
the
taxation_registry
branch
from
96d1795
to
e8f0ffc
Compare
arnolanglade
changed the title
|
@pjedrzejewski I will revert hte deletion of the |
arnolanglade
force-pushed
the
taxation_registry
branch
2 times, most recently
from
bbf1414
to
745878b
Compare
arnolanglade
changed the title
|
@Sylius/core-team / @michalmarcinkowski any feedback ? |
arnolanglade
force-pushed
the
taxation_registry
branch
from
745878b
to
678044e
Compare
|
@pjedrzejewski any feedback ? |
|
ping @pjedrzejewski |
pjedrzejewski
pushed a commit
that referenced
this pull request
Sep 3, 2015
[TaxationBundle] DelegatingCalculator use the ServiceRegistry
|
How many pings it takes to get something merged? Answer: Ping! 💃 Thank you Arnaud! |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[TaxationBundle] DelegatingCalculator use the ServiceRegistry
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[TaxationBundle] DelegatingCalculator use the ServiceRegistry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@Sylius/core-team what do you think ?