Replace dot with underscore in parameter name. #3010
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dots are replaced by underscores in PHP parser, so we should avoid using dot in cookie name.
pjedrzejewski
pushed a commit
that referenced
this pull request
Jul 16, 2015
Replace dot with underscore in parameter name.
|
Thank you Ka Yue! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bug fix: yes
BC break: no
Dots are replaced by underscores in PHP, so we should avoid using dot in parameter name. (ie: cookie name)
Without this fix,
CookieStoragewill not be able to retrieve what it set.See more discussion in Symfony: symfony/symfony#9009