Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Addressing] Countries management - enabling & disabling #3074

Merged
merged 2 commits into from
Aug 13, 2015
Merged

[Addressing] Countries management - enabling & disabling #3074

merged 2 commits into from
Aug 13, 2015

Conversation

pamil
Copy link
Contributor

@pamil pamil commented Jul 22, 2015

What was done, it's a massive PR:

  • Country translation based on ISO country code and Intl Symfony2 component
  • Country management improved, ability to add new countries (from list) and enable or disable existing ones, removed ability to delete countries due to unspecified behaviour of present and previous orders based on address with that country etc.
  • Removed redunant comments and fluent interface in Country

Based on #3098 and #3035.

@pamil pamil changed the title [WIP] Countries management - enabling & disabling [WIP] [Addressing] Countries management - enabling & disabling Jul 22, 2015
@pamil pamil force-pushed the countries-management branch 16 times, most recently from 50d359a to a06c438 Compare July 28, 2015 08:57
@pamil pamil mentioned this pull request Jul 28, 2015
Closed
@pamil pamil force-pushed the countries-management branch 2 times, most recently from bc2db63 to 65e234e Compare July 28, 2015 13:53
@pamil pamil changed the title [WIP] [Addressing] Countries management - enabling & disabling [Addressing] Countries management - enabling & disabling Jul 28, 2015
@pamil pamil mentioned this pull request Jul 28, 2015
Closed
@pamil pamil force-pushed the countries-management branch 5 times, most recently from 9c6629a to 5c68df9 Compare July 30, 2015 14:18
@pamil pamil mentioned this pull request Jul 30, 2015
Merged
@pamil pamil force-pushed the countries-management branch 2 times, most recently from 328f15d to d88acdb Compare July 31, 2015 08:33
@pamil pamil force-pushed the countries-management branch 16 times, most recently from 5362b11 to e672022 Compare August 4, 2015 12:38
@michalmarcinkowski michalmarcinkowski mentioned this pull request Aug 10, 2015
Closed
@pjedrzejewski pjedrzejewski added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Aug 13, 2015
@pjedrzejewski pjedrzejewski added this to the v0.15.0 milestone Aug 13, 2015
@pamil pamil force-pushed the countries-management branch 3 times, most recently from ee2ffbc to f72b22f Compare August 13, 2015 12:30
gperdomor and others added 2 commits August 13, 2015 19:39
pjedrzejewski pushed a commit that referenced this pull request Aug 13, 2015
Merge pull request #3074 from pamil/countries-management
e0009b2 
[Addressing] Countries management - enabling & disabling
@pjedrzejewski pjedrzejewski merged commit e0009b2 into Sylius:master Aug 13, 2015
@pjedrzejewski
Copy link
Member

@pamil Awesome work Kamil! 👍 Thank you and @gperdomor! You rock guys.

@michalmarcinkowski michalmarcinkowski mentioned this pull request Aug 17, 2015
Closed
@pamil pamil deleted the countries-management branch August 24, 2015 12:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
v0.15.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pamil @pjedrzejewski @gperdomor