Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TRANSLATION]Payment method translation #3079

Merged
merged 3 commits into from
Oct 21, 2015

Conversation

paullla
Copy link
Contributor

@paullla paullla commented Jul 23, 2015

No description provided.

@foopang
Copy link
Contributor

foopang commented Jul 28, 2015

Missing Doctrine migrations script?

@paullla paullla changed the title Payment method translation added [WIP]Payment method translation added Aug 19, 2015
@paullla paullla force-pushed the PaymentMethodTranslation branch 3 times, most recently from 957e1df to cd56544 Compare October 12, 2015 12:15
@antonioperic
Copy link
Contributor

@pjedrzejewski ping

@paullla paullla changed the title [WIP]Payment method translation added [TRANSLATION]Payment method translation added Oct 12, 2015
@paullla paullla changed the title [TRANSLATION]Payment method translation added [TRANSLATION]Payment method translation Oct 12, 2015
@pjedrzejewski pjedrzejewski added this to the v0.16.0 milestone Oct 19, 2015
@@ -76,6 +76,29 @@ private function addClassesSection(ArrayNodeDefinition $node)
->scalarNode('choice')->defaultValue('Sylius\Bundle\PaymentBundle\Form\Type\PaymentMethodChoiceType')->end()
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please revert the permissions change.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pjedrzejewski Can you please explain what you mean by permissions change?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File permissions. :)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how to revert that :)

@pjedrzejewski
Copy link
Member

Nice work Paula, sorry for the looong waiting. Could you also update data fixtures? (inside FixturesBundle) Thank you very much! 👍 /cc @antonioperic

@@ -0,0 +1,33 @@
<?php

namespace Sylius\Bundle\PaymentBundle\Form\Type;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing license header.

pjedrzejewski pushed a commit that referenced this pull request Oct 21, 2015
[TRANSLATION]Payment method translation
@pjedrzejewski pjedrzejewski merged commit 1197b3e into Sylius:master Oct 21, 2015
@pjedrzejewski
Copy link
Member

Thank you very much Paula, nice work! 👍

@paullla
Copy link
Contributor Author

paullla commented Oct 21, 2015

Thank you :)

@umpirsky
Copy link
Contributor

@paullla Welcome to Sylius family. Čestitam! :)

@paullla
Copy link
Contributor Author

paullla commented Oct 22, 2015

@umpirsky thank you :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants