Update routing.yml #3169
Merged
Update routing.yml #3169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Definitely in favor of changing the prefix. I know I am picky, but is it always a social login? :P This is basically OAuth. Any ideas for better name? If nobody comes up with something better, then we keep social, which is quite clear. :) Good idea Argi! 👍 |
pjedrzejewski
added
the
Enhancement
|
connect-login/ ? |
|
or connect/login/ since the other section for the routing is already under connect/ |
|
@pjedrzejewski what do you think? |
Hello there, This is a small proposal for routing name change. We've realised that using /login for both normal registered users and also social login buttons can be a bit confusing. This also takes into consideration that a user might add a trailing slash at the end, which currently is a "white page" on demo.sylius.org. What do you think? Cheers, Argiris changing social to connect
|
@pjedrzejewski @peteward updated |
|
Sounds good. Thank you guys! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello there,
This is a small proposal for routing name change. We've realised that using /login for both normal registered users and also social login buttons can be a bit confusing.
This also takes into consideration that a user might add a trailing slash at the end, which currently is a "white page" on demo.sylius.org.
What do you think?
Cheers,
Argiris