Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Behat] [DX] Added useful, developer-friendly steps, polished formatting #3170

Merged
merged 1 commit into from
Sep 1, 2015

Conversation

pamil
Copy link
Contributor

@pamil pamil commented Aug 21, 2015

Based on #3176.

Changes:

  • Given there is default channel configured, Given there is default currency configured, Given there are locales: | en_US | combined to one step Given store has default configuration
  • Removed unnecessary scenarios and steps, eg. Javascript's doubled delete scenarios or unused steps in shipments.feature background
  • Added:
    • Given all products are available in all variations
  • Renamed:
    • Given all products assigned to [...] channel to Given all products are assigned to [...] channel
    • Given all promotions assigned to [...] channel to Given all promotions are assigned to [...] channel
  • Bunch of aliases:
    • Given all products are assigned to the default channel instead of Given all products assigned to "DEFAULT_WEB" channel
    • Given all promotions are assigned to the default channel instead of Given all promotions assigned to "DEFAULT_WEB" channel
    • Given the default channel has following configuration instead of Given channel "DEFAULT_WEB" has following configuration
  • Moved Given I am logged in as ... step at the end of background, because usually it's the first step that slows down

@pamil pamil force-pushed the behat-dx branch 2 times, most recently from a73810a to 75defe6 Compare August 21, 2015 14:59
@michalmarcinkowski michalmarcinkowski added the DX Issues and PRs aimed at improving Developer eXperience. label Aug 21, 2015
@michalmarcinkowski michalmarcinkowski added this to the v0.15.0 milestone Aug 21, 2015
@pjedrzejewski
Copy link
Member

Awesome! Could you have a look at the failing build please? 👍

@pamil
Copy link
Contributor Author

pamil commented Aug 24, 2015

@pjedrzejewski It should be up and running now :)

@pamil pamil force-pushed the behat-dx branch 11 times, most recently from 017ac06 to 2058af4 Compare August 31, 2015 07:39
michalmarcinkowski added a commit that referenced this pull request Sep 1, 2015
[Behat] [DX] Added useful, developer-friendly steps, polished formatting
@michalmarcinkowski michalmarcinkowski merged commit cf2c385 into Sylius:master Sep 1, 2015
@michalmarcinkowski
Copy link
Contributor

Thank you Kamil! 👍

@pjedrzejewski
Copy link
Member

👍

@pamil pamil deleted the behat-dx branch September 15, 2015 09:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Issues and PRs aimed at improving Developer eXperience.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants