[ReportBundle] Remove bi-directional dependency on the CoreBundle #3231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjedrzejewski
changed the title
|
I added the [WIP] tag to this PR. Thanks Adam! Let us know when it is ready for review. |
adamelso
force-pushed
the
report-bundle-cascade-dependencies
branch
from
481cdc0
to
a495e0f
Compare
adamelso
changed the title
|
Thanks Pawel, this is ready now. I managed to register the bundle in my project okay. |
|
Nice! Requires a rebase though. :) |
adamelso
force-pushed
the
report-bundle-cascade-dependencies
branch
from
a495e0f
to
6567cd8
Compare
|
@pjedrzejewski Done :) Though, I see that #3110 is merged, will I need to do it again? Incidently, the build is failing on PHP 5.3 as Doctrine Migrations now requires 5.4. |
|
@adamelso Yes, I'm afraid it will need one another rebase :) |
| @@ -34,7 +34,8 @@ | |||
| "stof/doctrine-extensions-bundle": "~1.1", | |||
| "sylius/resource-bundle": "0.16.*", | |||
| "sylius/money-bundle": "0.16.*", | |||
| "sylius/report": "0.16.*" | |||
| "sylius/registry": "0.16.*", | |||
| "sylius/report": "0.16.*" | |||
There was a problem hiding this comment.
@pamil okay great, because I need to correct this line here :D
adamelso
force-pushed
the
report-bundle-cascade-dependencies
branch
from
6567cd8
to
cd5c5f5
Compare
|
alright, good to go! :) |
|
👍 |
pjedrzejewski
pushed a commit
that referenced
this pull request
Sep 14, 2015
…cies [ReportBundle] Remove bi-directional dependency on the CoreBundle
|
Thank you Adam! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks for merging the other pull request, now the real issue - The ReportBundle is completely unusable because of the following error:
These missing services are registered by the CoreBundle, so I've moved them to the ReportBundle.
Additionally, I've grouped and sorted the service definitions in alphabetical order (it was getting really confusing otherwise).
Don't merge yet, though, I need to do some more work. Cheers.