Remove shameful red color from travis #327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
September 8, 2013 17:44
|
Waw this is a huge PR, don't forget to detail your changes please :p |
added 11 commits
September 19, 2013 12:38
|
@winzou A lot of commits, but not that much changes. I'll sum up everything in the PR description before merging. I'm amazed that I managed to fix this build while being sick. :D |
|
@pjedrzejewski maybe the sickness has unleashed some magical fixing powers in you |
pjedrzejewski
pushed a commit
that referenced
this pull request
Sep 20, 2013
[WIP] Remove shameful red color from travis
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
Mar 21, 2016
[Taxation] Fixes in TaxationBundle and TaxationComponent docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Except fixing the build, this PR involves few changes.
Based on the Spree payments implementation, I removed the
Transactionmodel and added thePaymentLogfor every Payment.Checkout has been reworked to use events. Taxes are applied right after adding any item to cart and recalculated on every change. Default tax zone is used if user hasn't entered the billing address. If billing address is present / changed, the taxes are recalculated accordingly. Shipping charges are applied via events too.