[Settings] Cache parameters after fetching as well as saving. #3280
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pjedrzejewski
added
the
Enhancement
pjedrzejewski
pushed a commit
that referenced
this pull request
Sep 17, 2015
[Settings] Cache parameters after fetching as well as saving.
|
Thank you Craig! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I tried to find any previous issues / PRs regarding this. Is this not something you guys wanted to do? The only issue I could see with this is if someone is using
file_systemcache or another persistent cache in dev mode that default value changes to their schemas wouldn't be reflected (Edit: actually maybe not, this only caches parameters from the database, so default values would change). This could easily be solved by usingarraycache in dev mode. As I see it right now the settings only get cached when saved but if you clear caches you'd have to go to your settings after warmup and save them again to benefit from any caching.