[Order] Remove fluent interfaces #3309
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HerbMat
commented
Sep 21, 2015
HerbMat
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Fixed tickets | no |
| License | MIT |
michalmarcinkowski
added
the
Enhancement
| @@ -270,8 +258,6 @@ public function removeItem(OrderItemInterface $item) | |||
| $item->setOrder(null); | |||
There was a problem hiding this comment.
This should be removed as item must be assigned to some order, otherwise it's broken.
There was a problem hiding this comment.
These changes are not related to this PR and that change should be discussed separately, same as all below.
michalmarcinkowski
added a commit
that referenced
this pull request
Sep 25, 2015
[Order] Remove fluent interfaces
|
👍 |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
…in-order [Order] Remove fluent interfaces
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.