Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Core] Remove fluent interfaces and add missing doc blocks #3319

Closed
wants to merge 1 commit into from
Closed

[Core] Remove fluent interfaces and add missing doc blocks #3319

wants to merge 1 commit into from

Conversation

HerbMat
Copy link
Contributor

@HerbMat HerbMat commented Sep 21, 2015

Q A
Bug fix? no
New feature? no
BC breaks? yes
Deprecations? no
Fixed tickets no
License MIT

michalmarcinkowski
michalmarcinkowski reviewed Sep 22, 2015
View reviewed changes
src/Sylius/Bundle/CoreBundle/Checkout/Step/PaymentStep.php
/**
* @param OrderInterface $order
*
* @return Form
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@return FormInterface

@pjedrzejewski pjedrzejewski added the Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). label Oct 20, 2015
@pjedrzejewski pjedrzejewski added this to the v0.16.0 milestone Oct 20, 2015
@pjedrzejewski
Copy link
Member

Hey @HerbMat, could you rebase this PR? Thank you! :)

@NoResponseMate NoResponseMate mentioned this pull request Nov 26, 2015
Closed
@pjedrzejewski pjedrzejewski removed this from the v0.16.0 milestone Dec 14, 2015
@okwinza
Copy link
Contributor

okwinza commented Feb 2, 2016

@pjedrzejewski this seems abandoned. Do you want me to pick it up?

@pjedrzejewski
Copy link
Member

@okwinza Sure thing! :)

@michalmarcinkowski
Copy link
Contributor

This was replaced by #4862.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.).
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@HerbMat @pjedrzejewski @okwinza @michalmarcinkowski