Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Api order type fix #3338

Merged
merged 2 commits into from
Sep 25, 2015
Merged

Conversation

lchrusciel
Copy link
Member

Q A
Bug fix? yes
New feature? yes
BC breaks? no
Deprecations? no
Fixed tickets
License MIT

Added new line in UserBundle configuration to auto generate customer choice type and Api OrderType fix.
Depends on #3332

@pjedrzejewski pjedrzejewski added this to the v0.16.0 milestone Sep 23, 2015
@@ -155,6 +155,7 @@ private function addClassesSection(ArrayNodeDefinition $node)
->scalarNode('registration')->defaultValue('Sylius\Bundle\UserBundle\Form\Type\CustomerRegistrationType')->end()
->scalarNode('simple_registration')->defaultValue('Sylius\Bundle\UserBundle\Form\Type\CustomerSimpleRegistrationType')->end()
->scalarNode('guest')->defaultValue('Sylius\Bundle\UserBundle\Form\Type\CustomerGuestType')->end()
->scalarNode('choice')->defaultValue('%sylius.form.type.resource_choice.class%')->end()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why this uses parameter as default value?

pjedrzejewski pushed a commit that referenced this pull request Sep 25, 2015
@pjedrzejewski pjedrzejewski merged commit 47d9ac4 into Sylius:master Sep 25, 2015
@pjedrzejewski
Copy link
Member

Thank you Łukasz!

@lchrusciel lchrusciel deleted the api-order-type-fix branch February 1, 2016 15:14
pamil pushed a commit to pamil/Sylius that referenced this pull request May 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants