Remove old closures compatibility code #3347
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
stloyd
commented
Sep 24, 2015
stloyd
commented
| Q | A |
|---|---|
| Bug fix? | no |
| BC breaks? | no |
| License | MIT |
stloyd
force-pushed
the
bugfix/clousures
branch
from
b076bca
to
0f7f56a
Compare
| ->validate(function () use ($cart) { | ||
| return !$cart->isEmpty(); | ||
| ->validate(function () { | ||
| return !$this->cartProvider->getCart()->isEmpty(); |
There was a problem hiding this comment.
Why not $this->getCurrentCart()->isEmpty()?
There was a problem hiding this comment.
TBH. I was not sure about this, and decided to not use protected method but direct call, can change if it's a problem.
There was a problem hiding this comment.
+1 for $this->getCurrentCart()->isEmpty() for the sake of code readability.
|
👍 |
1 similar comment
|
👍 |
stloyd
force-pushed
the
bugfix/clousures
branch
from
0f7f56a
to
7a0ca54
Compare
|
@pjedrzejewski ping :) |
pjedrzejewski
pushed a commit
that referenced
this pull request
Oct 19, 2015
Remove old closures compatibility code
|
Thank you Joseph! |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
Remove old closures compatibility code
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
Remove old closures compatibility code
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
Remove old closures compatibility code
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
Remove old closures compatibility code
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.