[User] Added missing unique indexes on customer.email and emailCanonical #3484
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@peteward Could you generate a database migration for that change? Thanks! |
pjedrzejewski
added
the
Enhancement
peteward
force-pushed
the
pw-unique-email
branch
from
1a01ded
to
76f8974
Compare
|
updated |
pjedrzejewski
pushed a commit
that referenced
this pull request
Oct 26, 2015
[User] Added missing unique indexes on customer.email and emailCanonical
|
Thank you very much Peter! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Import a million users to your database and you'll really need this index...
user.username and usernameCanonical seem to be nullable? so I haven't added any to this, although customer.email will be where db queries are mainly run against anyway.