Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI AppVeyor #3501

Merged
merged 1 commit into from Nov 6, 2015
Merged

CI AppVeyor #3501

merged 1 commit into from Nov 6, 2015

Conversation

mhujer
Copy link
Contributor

@mhujer mhujer commented Oct 29, 2015

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Fixed tickets none
License MIT
Doc PR none

This PR adds a config file for AppVeyor which is a CI similar to travis, except they run the builds on Windows machines. Therefore any possible incompatibilites can be easily discovered (ref #2604)

~~**It is still very WIP, I just want to:

  1. prevent possibly duplicate work, if someone starts working on the same thing
  2. get feedback as early as possible**~~

You can see the build output here https://ci.appveyor.com/project/mhujer/sylius

To integrate it with this project, it is necessary to login to https://ci.appveyor.com/ using github account and enable the build for this repo.

(Symfony has recently started to use AppVeyor - symfony/symfony#15575, that's where most of the config comes from)

@@ -20,6 +20,8 @@
],
"require": {
"php": ">=5.5.9",
"ext-exif": "*",
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Exif extension is not required by Sylius or any dependency, but if it is missing, it causes error during cache:warmup

php app\console cache:warmup --env=test

Warming up the cache for the test environment with debug true

  [Imagine\Exception\NotSupportedException]                     
  PHP exif extension is required to use the ExifMetadataReader  

@pjedrzejewski
Copy link
Member

This is awesome, thank you for your work Martin! 👍 I hope this is the first step in much better Windows support.

@pjedrzejewski pjedrzejewski added the DX Issues and PRs aimed at improving Developer eXperience. label Oct 30, 2015
@pjedrzejewski pjedrzejewski added this to the v1.0.0-ALPHA1 milestone Oct 30, 2015
@adamelso
Copy link
Contributor

aww beat me to it adamelso#6

but nice! 👍 I'll let you continue

@pjedrzejewski
Copy link
Member

@adamelso I like to have such problems in the community! :) Let's combine your work and get the best possible configuration. Would be great if you guys discuss your approaches.

@mhujer mhujer changed the title [WIP] CI AppVeyor CI AppVeyor Nov 6, 2015
- php app\console cache:warmup --env=test

- IF %TEST_SUITE%==phpspec travis\appveyor\suite-phpspec.cmd
- IF %TEST_SUITE%==1a travis\appveyor\suite-1a.cmd
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I needed to split the existing suites into two parts to fit into AppVeyor build time limit

pjedrzejewski pushed a commit that referenced this pull request Nov 6, 2015
@pjedrzejewski pjedrzejewski merged commit 90ffa4a into Sylius:master Nov 6, 2015
@mhujer mhujer deleted the appveyor branch November 6, 2015 19:35
@pjedrzejewski
Copy link
Member

Great work @mhujer! What configuration should I setup in AppVeyor? I have registered and added Sylius project. I merge this to see if it works, but I guess I will need to do a bit more setup. I really appreciate the effort you have put into this, it will make our life so much easier and hopefully we see less bug reports in Windows. :) 👍

@mhujer
Copy link
Contributor Author

mhujer commented Nov 6, 2015

@pjedrzejewski There shouldn't be any setup necesarry in the AppVeyor - you can either set it through the web UI or through the config file.

@mhujer
Copy link
Contributor Author

mhujer commented Nov 6, 2015

The only downside of the AppVeyor is that the build is quite slow 🐌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DX Issues and PRs aimed at improving Developer eXperience.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants