Configure adjustments api and permissions #3502
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
pjedrzejewski
commented
Oct 29, 2015
pjedrzejewski
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
| public function createNew() | ||
| { | ||
| if (null === $orderId = $this->getRequest()->get('orderId')) { | ||
| throw new NotFoundHttpException('No order id given.'); |
There was a problem hiding this comment.
just for consistency, isn't it better to use 'createNotFoundException' method? In that case we don't need to have 'NotFoundHttpException' here.
There was a problem hiding this comment.
Actually this should throw 400 bad request.
👍 for createNotFound in condition below
pjedrzejewski
force-pushed
the
add-adjustments-api
branch
from
91b8165
to
d83d266
Compare
michalmarcinkowski
added a commit
that referenced
this pull request
Oct 30, 2015
Configure adjustments api and permissions
|
Thanks Paweł! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.