-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[User] Decoupled password encoders and updaters from UserInterface #3504
Conversation
Is this name a result of fun discussion in the office? :D |
@pjedrzejewski, flawless observation. 👍 |
@TheMadeleine @pamil Are we sure it makes sense? Credentialing means something a bit different as far as I know/googled. Perhaps CredentialsHolderInterface or let's go full-Javan SecurityCredentialsHolderInterface? |
IMO this interface is useles... What's the real point for it? Are so commonly re-use this interface somehow? |
@stloyd right now I have to implements UserBundle's |
@pjedrzejewski |
…ndle/UserBundle/Model/UserInterface
…ur of CredentialingInterface
8c1d844
to
fb53c0b
Compare
[User] Decoupled password encoders and updaters from UserInterface
Thank you Kamil! |
Introduced
CredentialingInterface
which implementation needs to be passed to password encoders and updaters instead ofUserInterface
with methods likesetCustomer()
etc.