Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[User] Decoupled password encoders and updaters from UserInterface #3504

Merged
merged 4 commits into from
Oct 30, 2015

Conversation

pamil
Copy link
Contributor

@pamil pamil commented Oct 30, 2015

Q A
Bug fix? no
New feature? yes
BC breaks? no
Deprecations? no
License MIT

Introduced CredentialingInterface which implementation needs to be passed to password encoders and updaters instead of UserInterface with methods like setCustomer() etc.

@pjedrzejewski
Copy link
Member

Is this name a result of fun discussion in the office? :D

@CoderMaggie
Copy link
Member

@pjedrzejewski, flawless observation. 👍

@pjedrzejewski
Copy link
Member

@TheMadeleine @pamil Are we sure it makes sense? Credentialing means something a bit different as far as I know/googled. Perhaps CredentialsHolderInterface or let's go full-Javan SecurityCredentialsHolderInterface?

@stloyd
Copy link
Contributor

stloyd commented Oct 30, 2015

IMO this interface is useles... What's the real point for it? Are so commonly re-use this interface somehow?

@pamil
Copy link
Contributor Author

pamil commented Oct 30, 2015

@stloyd right now I have to implements UserBundle's UserInterface which ships with Customer relation, OAuthAccounts relation and all the stuff I don't really need in my project. This interface will let me use UserBundle's PasswordUpdater and PasswordEncoder.

@pamil
Copy link
Contributor Author

pamil commented Oct 30, 2015

@pjedrzejewski CredentialsHolderInterface looks promising and way more understandable, thanks! :)

pjedrzejewski pushed a commit that referenced this pull request Oct 30, 2015
[User] Decoupled password encoders and updaters from UserInterface
@pjedrzejewski pjedrzejewski merged commit a5b4100 into Sylius:master Oct 30, 2015
@pjedrzejewski
Copy link
Member

Thank you Kamil!

@pamil pamil deleted the user-utils-decoupled branch October 30, 2015 19:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants