Issue #350 fix

[antonioperic]

No description provided.

[stloyd]

This should be reverted and added to your global .gitignore

[antonioperic]

Done! Thnx 👍

[Richtermeister]

I'm actually not 100% sure what's going on here, but I also noticed that the order numbers currently aren't being generated. What I can't figure out - how does "sylius.order.pre_create" ever get triggered? Is that happening on the Doctrine/Persistence level?

Also, just to confirm, are we generating order numbers only when orders are getting confirmed? That would seem to be the correct behavior, so we don't waste order numbers on temporary carts..

Thanks for helping me understand :)

[antonioperic]

HI,

you can call it with:
$this->get('event_dispatcher')->dispatch('sylius.order.post_create', new GenericEvent($order));
where ever you want

i think that this will work also:
$this->dispatchCheckoutEvent('sylius.order.post_create', $order);

I agree with your logic that we should generate number only on completing order

[antonioperic]

Another idea for this is to create class inside SalesBundle that will have OrderEvents (Similar as FosUserEvents) and than use that event inside Checkout process

What do you think about that? I think this is elegant solution and we can use SalesBundle as independent .

@pjedrzejewski @stloyd ?

[antonioperic]

Also as I see at the moment FINALIZE_* events doesn't do nothing. Maybe to implement same logic as for order.pre_complete inside finalize.... but that will be reinventing the wheel maybe :/

[stloyd]

Closing as the issue was probably fixed by #404.

[pjedrzejewski]

^ confirmed.