Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix translation for backend product undelete btn #3510

Merged
merged 1 commit into from
Nov 2, 2015

Conversation

diimpp
Copy link
Member

@diimpp diimpp commented Oct 31, 2015

Q A
Bug fix? yes
New feature? no
BC breaks? no
Deprecations? no
License MIT

Fixes actions undelete button
http://demo.sylius.org/administration/products/?deleted=1

Let me know, if I should rename translation string from sylius.product.delete_revert to sylius.product.delete_restore.

@pjedrzejewski
Copy link
Member

Actually, according to new translation key conventions (will be published soon when we finish migration script) it should be just sylius.restore. Wdyt?

@pjedrzejewski pjedrzejewski added Bug Fix UX Issues and PRs aimed at improving User eXperience. labels Oct 31, 2015
@pjedrzejewski pjedrzejewski added this to the v0.16.0 milestone Oct 31, 2015
@diimpp
Copy link
Member Author

diimpp commented Oct 31, 2015

Yes, this particular key should be move out of product namespace to general one for sure.

Looking forward to see new conventions.

@pjedrzejewski
Copy link
Member

@diimpp This will take a few more days at least, so I will be happy to merge your change before that. Just tweak the key and we are good to go, thank you. :)

@diimpp
Copy link
Member Author

diimpp commented Nov 1, 2015

@pjedrzejewski done

pjedrzejewski pushed a commit that referenced this pull request Nov 2, 2015
Fix translation for backend product undelete btn
@pjedrzejewski pjedrzejewski merged commit 9abc2e6 into Sylius:master Nov 2, 2015
@pjedrzejewski
Copy link
Member

Thank you @diimpp. We should not modify any other translation files than en, cause they are overriden when syncing with Crowdin anyway. 👍

@diimpp
Copy link
Member Author

diimpp commented Nov 2, 2015

@pjedrzejewski sorry, I've missed another usage of this trans key. Here is hotfix #3516 It's last one for sure. :)

Will keep in mind about other translation files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
UX Issues and PRs aimed at improving User eXperience.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants