[ResourceBundle] Search id or slug in request query strings

[SebLours]

A POST, PUT or PATCH request like this:

{
    "country_code": "FR",
    "first_name": "First name",
    "last_name": "Last name",
    "slug": "my-slug"
}

throws a 404 response because the slug became a default search criteria.

[pjedrzejewski]

The thing is, we may want display something by slug, which is in the request attributes. (eg. /foo/{slug})

This change works for Sylius, but in the case I mentioned above with custom resources it can be a problem. Perhaps we should look in the query AND attributes bag? What do you think? That would skip the "request" bag because it does not make sense to look there anyway.

[SebLours]

Hi Pawel,

Of course, you're right.
Now request's attributes & query are tested.

if ($request->attributes->has('slug') || $request->query->has('slug')) {
    $default = array('slug' => $request->get('slug'));
} elseif ($request->attributes->has('id') || $request->query->has('id')) {
    $default = array('id' => $request->get('id'));
} else {
    $default = array();
}

[pjedrzejewski]

Perfect, thank you very much Sébastien!