[PayumBundle] Added payment total to Paypal Express Checkout request #3577
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
GSadee
commented
Nov 17, 2015
GSadee
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets | |
| License | MIT |
| Doc PR |
| } | ||
|
|
||
| if (0 !== $paymentTotal = $order->getAdjustmentsTotal(AdjustmentInterface::PAYMENT_ADJUSTMENT)) { | ||
| $details['L_PAYMENTREQUEST_0_NAME'.$m] = 'Payment Total'; |
There was a problem hiding this comment.
Should be "Payment Fee Total".
Payment Total alone is really confusing, because this is not really total amount of payment.
pjedrzejewski
added
Bug Fix
Critical
GSadee
force-pushed
the
preparing-paypal-express-checkout-fixes
branch
from
f20e3a9
to
3a1b69b
Compare
GSadee
force-pushed
the
preparing-paypal-express-checkout-fixes
branch
from
3a1b69b
to
19d4693
Compare
pjedrzejewski
pushed a commit
that referenced
this pull request
Nov 18, 2015
…t-fixes [PayumBundle] Added payment total to Paypal Express Checkout request
|
Thank you Grzesiu! :) |
|
|
||
| if (0 !== $paymentTotal = $order->getAdjustmentsTotal(AdjustmentInterface::PAYMENT_ADJUSTMENT)) { | ||
| $details['L_PAYMENTREQUEST_0_NAME'.$m] = 'Payment Fee Total'; | ||
| $details['L_PAYMENTREQUEST_0_AMT'.$m] = round($paymentTotal / 100, 2); |
There was a problem hiding this comment.
not sure it should be hard coded to 2. Some currencies may have different amount of digits after the point.
I am doing it this way https://github.com/Payum/Payum/blob/master/src/Payum/Paypal/ExpressCheckout/Nvp/Action/ConvertPaymentAction.php#L27
There was a problem hiding this comment.
We do not have this configuration on currencies yet. :( But we will definitely look into this issue.
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
…heckout-fixes [PayumBundle] Added payment total to Paypal Express Checkout request
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.