Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Travis] Composer-related performance optimzations #3596

Merged
merged 2 commits into from
Nov 20, 2015

Conversation

pamil
Copy link
Contributor

@pamil pamil commented Nov 20, 2015

  • Travis now does not implicitly run cache:clear / assets:install while installing packages by Composer
  • Fixed composer.lock caching (while requiring doctrine/mongodb-odm)
  • Removed ~/.composer from Travis cache

Doing these things makes that every build, that does not change composer.json or composer.lock, will not have to upload new cache archive, which usually takes about 40-60s. Moreover, cache archives will be smaller so we will save another second or two here.

@@ -77,7 +77,8 @@
"twig/twig": "~1.11",
"white-october/pagerfanta-bundle": "~1.0",
"willdurand/hateoas-bundle": "~0.4",
"winzou/state-machine-bundle": "~0.2"
"winzou/state-machine-bundle": "~0.2",
"doctrine/mongodb-odm": "^1.0.2"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be reverted, it's optional not required.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍, haven't deleted it after testing composer cache script

@pamil pamil force-pushed the travis-optimizing branch 2 times, most recently from eeee149 to 24cb4e8 Compare November 20, 2015 14:36
pjedrzejewski pushed a commit that referenced this pull request Nov 20, 2015
[Travis] Composer-related performance optimzations
@pjedrzejewski pjedrzejewski merged commit 84a11ba into Sylius:master Nov 20, 2015
@pjedrzejewski
Copy link
Member

Nice, 30 mins... what the hell! :) Thanks Kamil!

@pamil pamil deleted the travis-optimizing branch November 26, 2015 12:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants