[Attribute] Attribute types system modification

[Zales0123]

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	yes
Deprecations?	no
Fixed tickets
License	MIT
Doc PR	Sylius/Sylius-Docs#369

PR contains basic implementation of new attribute types system. It is partially inspired by Akeneo.
Each attribute type is now separate service, which is defined with type, storage type, form type etc. AttributeValue value is stored in database based on attribute type storageType.
For now, there are few simple attribute types implemented:

• checkbox
• date
• datetime
• integer
• percent
• textarea
• text

Each of them has corresponding form type and it's name is set as 'sylius_attribute_type_'.$type.
Also creating attribute and adding attribute to product UI's have changed a little bit.

Attribute type is chosen as a first step of creation and it's not possible to change it later:

While adding attribute to product, we first choose target attributes from modal. It is possible to pick more than one attribute at once. Added attribute forms are rendered with AJAX request.

It is really preliminary PR, so there is lots of work to do:

• add options to attributes (e.g. min/max length to text, start/end date to datetime etc.)
• add an awesome validation system, that will allows to validate easily each attribute type
• implement some more default types (I would appreciate any ideas, as my creativity is unfortunately limited :))

[pjedrzejewski]

I think these constants should be on *AttributeType classes
Storage type constants should live on AttributeValueInterface, because this is where we have storages defined. Wdyt?

[pjedrzejewski]

So, here should be self::TYPE.

[pamil]

Or even static::TYPE so we can overwrite the contents of constant in child class.

[Zales0123]

@pjedrzejewski 👍 @pamil 👍

[pjedrzejewski]

Also, when we are at it - we should remove Presentation and make the name translatable.

Previously, name was serving as a unique code, now we have proper code property, so let's remove presentation and replace it with name. Make sure to keep it translatable. 👍

[pjedrzejewski]

@Zales0123 And code should be unique, immutable after an attribute is created.

[aramalipoor]

This is great job thanks @Zales0123, It would be awesome if we could have something like this for Options too.

It would be great if we could have a display type (alongside form and storage) which is the way we render the attribute/option in storefront e.g.:

• Boolean type (Does it have bluetooth?) (✓)
• Color palette type (T-Shirt's color)
• Image type (Dress's pattern)

[pjedrzejewski]

@aramalipoor For options - we will think about it. Actually, at some point I was thinking that Attributes could be used instead of Options in general - just like Akeneo does it, but it is complex and probably not for 1.0.

Regarding rendering - for attributes we plan to do it simple for now, where every attribute type will be able to have it's own template. Or even being able to select the template in backend from some list, defined ... somewhere, not sure where yet. :) Goal is to get this basic version merged (with validation and simple rendering) and then expand it even more - introduce scope (per channel), translatable values and unique attribute validation stuff.

[Zales0123]

@pjedrzejewski Sure thing about presentation and code, I don't know why it's not implemented now, as it is quite obvious :)
@aramalipoor Thank you very much for your appreciation, I hope it's going to be easy and fun to play with attributes after this PR will be merged.

[aramalipoor]

@pjedrzejewski That's awesome man! It's better to improve step by step ;)
@Zales0123 I'm waiting for this PR to implement it in our app ;)

[tristanbes]

I send love to this PR ❤️ great job !

[Zales0123]

@tristanbes Thank you for such a great optimism 😄 I really hope this change will reach expectations :)

[Zales0123]

@pjedrzejewski @michalmarcinkowski @pamil @lchrusciel @stloyd @tuka217 @Arminek (plenty of people, isn't it?) Thank you all for the review :) I hope these changes that I've just pushed are final. I know there are some things to improve (some very good points from @pjedrzejewski) and I will be very happy to manage them on the base of this PR in the nearest future (at least I will try 😄)

[pjedrzejewski]

Boom! 💥 Thank you Mateusz! Great work. 👍

Anyone willing to add more configurations/validation or even whole new attribute types? Should be simple after this is merged. :)