Stateless cart provider #3637
Merged
Stateless cart provider #3637
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PWalkow
force-pushed
the
stateless-cart-provider
branch
from
819a6b5
to
f0cc651
Compare
| @@ -48,11 +48,11 @@ class CartProvider implements CartProviderInterface | |||
| protected $cartFactory; | |||
|
|
|||
| /** | |||
| * Cart repository. | |||
| * Cart Repository. | |||
There was a problem hiding this comment.
Quite obvious, don't you think?
pjedrzejewski
added
RFC
| $eventDispatcher->dispatch(SyliusCartEvents::CART_INITIALIZE, Argument::any())->shouldBeCalled(); | ||
| $cartRepository->find()->shouldNotBeCalled(); | ||
|
|
||
| $this->initialize_cart_should_be_called_on($eventDispatcher); |
There was a problem hiding this comment.
Spec's are not the classes, so it is not a good practice to remove duplications. I found it less readable with this private method. And instead of reading what it should do, I have to jump to private declaration. And it is used only twice. Remove this method.
PWalkow
force-pushed
the
stateless-cart-provider
branch
5 times, most recently
from
e4bba40
to
20ee12c
Compare
PWalkow
force-pushed
the
stateless-cart-provider
branch
from
20ee12c
to
43d9e0b
Compare
|
Ready. |
|
Feedback please, this is underpinning sorting out finances. |
pjedrzejewski
pushed a commit
that referenced
this pull request
Nov 29, 2015
Stateless cart provider
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Services should be stateless. CartProvider holding cart was just premature optimisation and just wrong.