[Payment][PaymentBundle] Add immutable code to Payment entities #3666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tuka217
commented
Dec 2, 2015
tuka217
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | yes |
| Deprecations? | no |
| Fixed tickets | #3639, #3617 |
| License | MIT |
| Doc PR | - |
tuka217
force-pushed
the
immutable-code-payment
branch
6 times, most recently
from
e0594d4
to
a03d127
Compare
tuka217
changed the title
tuka217
force-pushed
the
immutable-code-payment
branch
4 times, most recently
from
bd85f66
to
454f8a3
Compare
| @@ -128,3 +132,15 @@ Feature: Payment methods | |||
| And I click "delete" from the confirmation modal | |||
| Then I should still be on the payment method index page | |||
| And I should not see payment method with name "PayPal" in that list | |||
|
|
|||
| Scenario: Cannot update shipping method code | |||
There was a problem hiding this comment.
I suppose you meant payment method 😉 Same below
tuka217
force-pushed
the
immutable-code-payment
branch
4 times, most recently
from
ee9b4c2
to
7c82aa4
Compare
|
Please rebase. |
tuka217
force-pushed
the
immutable-code-payment
branch
from
7c82aa4
to
64905eb
Compare
|
@tuka217 Could you reduce this PR to a single commit? If rebase did not help then you maybe need to cherry-pick the last commit - it will be easier. I see 4 commits which should not be part of this PR. |
| @@ -73,6 +73,11 @@ function it_builds_form_with_proper_fields( | |||
| ->shouldBeCalled() | |||
| ; | |||
|
|
|||
| $builder | |||
| ->addEventSubscriber(Argument::type('Sylius\Bundle\ResourceBundle\Form\EventSubscriber\AddCodeFormSubscriber')) | |||
There was a problem hiding this comment.
Argument::type(AddCodeFormSubscriber::class)
tuka217
force-pushed
the
immutable-code-payment
branch
from
64905eb
to
9777952
Compare
…ce extends CodeAwareInterface [PaymentBundle] PaymentMethodType add AddCodeFormSubscriber to builder
tuka217
force-pushed
the
immutable-code-payment
branch
from
9777952
to
80aa11d
Compare
pjedrzejewski
pushed a commit
that referenced
this pull request
Dec 10, 2015
[Payment][PaymentBundle] Add immutable code to Payment entities
|
Thank you again Ania! :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.