Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Taxation][TaxationBundle] Add immutable code to Taxation entities #3667

Merged
merged 1 commit into from
Dec 10, 2015
Merged

[Taxation][TaxationBundle] Add immutable code to Taxation entities #3667

merged 1 commit into from
Dec 10, 2015

Conversation

tuka217
Copy link
Contributor

@tuka217 tuka217 commented Dec 2, 2015

Q A
Bug fix? no
New feature? yes
BC breaks? yes
Deprecations? no
Fixed tickets #3639, #3617
License MIT
Doc PR -

@tuka217 tuka217 force-pushed the immutable-code-taxation branch 5 times, most recently from 5a8ca60 to b627f10 Compare December 4, 2015 08:35
@tuka217 tuka217 changed the title [WIP][Taxation][TaxationBundle] Add immutable code to Taxation entities [Taxation][TaxationBundle] Add immutable code to Taxation entities Dec 4, 2015
@tuka217 tuka217 force-pushed the immutable-code-taxation branch 4 times, most recently from a79e069 to cb0a407 Compare December 9, 2015 10:11
michalmarcinkowski
michalmarcinkowski reviewed Dec 9, 2015
View reviewed changes
features/backend/tax_categories.feature
When I fill in "Name" with "Computers"
And I press "Create"
Then I should still be on the tax category creation page
And I should see "Please enter tax category code."
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing blank line at the end of a file.

@tuka217 tuka217 force-pushed the immutable-code-taxation branch 2 times, most recently from 0fd3801 to 0eae0f1 Compare December 9, 2015 11:11
@pjedrzejewski
Copy link
Member

Please squash the commits and have a look at the failing build.

@tuka217
[TaxationBundle] Add event subscriber AddCodeFormSubscriber to TaxRat…
ffb4779 
…eType and TaxCategoryType

[TaxationBundle] Add validation  for filed 'code' from TaxRate and TaxCategory
[Taxation] Add field 'code' to TaxCategory and TaxRate, TaxCategoryInterface and TaxRateInterface extend AwareCodeInterface
[WebBundle] Add code filed to TaxCategory views and to TaxRate views
pjedrzejewski pushed a commit that referenced this pull request Dec 10, 2015
Merge pull request #3667 from tuka217/immutable-code-taxation
26c7bb4 
[Taxation][TaxationBundle] Add immutable code to Taxation entities
@pjedrzejewski pjedrzejewski merged commit 26c7bb4 into Sylius:master Dec 10, 2015
@pjedrzejewski
Copy link
Member

Thank you Ania! 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@tuka217 @pjedrzejewski @michalmarcinkowski