[Currency] Introduce immutable code for Currency #3675
Conversation
tuka217
commented
Dec 4, 2015
tuka217
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
tuka217
force-pushed
the
immutable-code-currency
branch
from
6212d54
to
bd7a20b
Compare
|
|
||
| Scenario: Cannot update currency code | ||
| When I am editing currency with code "USD" | ||
| Then The code field should be disabled |
There was a problem hiding this comment.
Why? In all steps after 'Then' we starts sentence with capital letter.
There was a problem hiding this comment.
If yes, we should not :) We start with capital "I" and it is correct, due to english grammar rules. However, other words should be wrote down with lowercase (as i.e. Given store has default configuration).
Moreover, in more abstract way of thinking, we always start sentence with capital letter, because keyword is part of the sentence! 😄 Making behat scenarios more natural means also thinking about them as natural language, I suppose :)
tuka217
force-pushed
the
immutable-code-currency
branch
4 times, most recently
from
b5c76fb
to
b1f5a92
Compare
| public function __construct($type = 'text') | ||
| { | ||
| $this->type = $type; | ||
| } |
There was a problem hiding this comment.
Missing blank line after this.
tuka217
force-pushed
the
immutable-code-currency
branch
3 times, most recently
from
fec0b82
to
0da7656
Compare
tuka217
changed the title
| $this->addSql('ALTER TABLE sylius_channel DROP FOREIGN KEY FK_16C8119EECD792C0'); | ||
| $this->addSql('DROP INDEX IDX_16C8119E743BF776 ON sylius_channel'); | ||
| $this->addSql('DROP INDEX IDX_16C8119EECD792C0 ON sylius_channel'); | ||
| $this->addSql('ALTER TABLE sylius_channel DROP default_locale_id, DROP default_currency_id'); |
There was a problem hiding this comment.
The migration is incorrect and should be removed.
[CurrencyBundle] Add AddCodeFormSubscriber to CurrencyType [ResourceBundle] Modify AddCodeFormSubscriber to make possible passing type of code field [Currency] Introduce code for Currency
tuka217
force-pushed
the
immutable-code-currency
branch
from
0da7656
to
3ce46f7
Compare
[Currency] Introduce immutable code for Currency
|
Thank you Ania! |
