[Addressing] Removed Address relations and introduced CodeAwareInterface #3696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
NoResponseMate
commented
Dec 9, 2015
NoResponseMate
commented
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | yes |
| BC breaks? | yes |
| Deprecations? | no |
| Fixed tickets | #1536, #2561, #3066 |
| License | MIT |
| Doc PR | - |
NoResponseMate
changed the title
NoResponseMate
force-pushed
the
rework-addressing
branch
from
de08c48
to
be29ffa
Compare
pjedrzejewski
added
the
Enhancement
| @@ -39,6 +39,7 @@ Feature: Zones | |||
|
|
|||
| Scenario: Creating new zone requires adding at least 1 member | |||
| Given I am on the zone creation page | |||
| And I fill in "Code" with "EU-Zone" | |||
There was a problem hiding this comment.
I'd use EU code here and "European Union" as name, makes more sense. :)
NoResponseMate
force-pushed
the
rework-addressing
branch
from
be29ffa
to
3a1495b
Compare
NoResponseMate
force-pushed
the
rework-addressing
branch
7 times, most recently
from
e49b462
to
c825620
Compare
NoResponseMate
force-pushed
the
rework-addressing
branch
12 times, most recently
from
8a3073a
to
10d201e
Compare
| /** | ||
| * @var RepositoryInterface | ||
| */ | ||
| protected $repository; |
There was a problem hiding this comment.
$zoneRepository
NoResponseMate
force-pushed
the
rework-addressing
branch
4 times, most recently
from
b601660
to
2fe7026
Compare
NoResponseMate
force-pushed
the
rework-addressing
branch
from
2fe7026
to
ce17eae
Compare
pjedrzejewski
pushed a commit
that referenced
this pull request
Jan 14, 2016
[Addressing] Removed Address relations and introduced CodeAwareInterface
|
Thank you Jasiek, great work! |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[Addressing] Removed Address relations and introduced CodeAwareInterface
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.