[Rbac][RbacBundle] Introduce code for Rbac #3730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
tuka217
commented
Dec 16, 2015
tuka217
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | yes |
| BC breaks? | no |
| Deprecations? | no |
| Fixed tickets | - |
| License | MIT |
| Doc PR | - |
tuka217
changed the title
tuka217
force-pushed
the
immutable-code-rbac
branch
2 times, most recently
from
a1d4117
to
94d9eca
Compare
tuka217
changed the title
tuka217
force-pushed
the
immutable-code-rbac
branch
from
94d9eca
to
7f3be22
Compare
tuka217
changed the title
| return; | ||
| } | ||
|
|
||
| if(!$resource instanceof RoleInterface && !$resource instanceof PermissionInterface) { |
tuka217
force-pushed
the
immutable-code-rbac
branch
3 times, most recently
from
89216c6
to
d2f1ede
Compare
|
|
||
| function it_is_initializable() | ||
| { | ||
| $this->shouldHaveType(AddParentFormSubscriber::class); |
There was a problem hiding this comment.
You should use FQCN in this one instead of ::class as stated in #3736 (comment)
|
Requires rebasing. |
tuka217
force-pushed
the
immutable-code-rbac
branch
from
d2f1ede
to
4c8e12e
Compare
| throw new UnexpectedTypeException($resource, RoleInterface::class, PermissionInterface::class); | ||
| } | ||
|
|
||
| if (null === $resource->getId() XOR null === $resource->getParent()) { |
There was a problem hiding this comment.
This condition changes the previous behavior:
ConditionBefore (remove parent when true):
null !== $permission->getId() && null === $permission->getParent()
ConditionNow (add parent when false):
null === $resource->getId() XOR null === $resource->getParent()
| ID | Parent | ResultBefore | ResultNow |
|---|---|---|---|
| null | null | add parent | add parent |
| null | not null | add parent | no parent |
| not null | null | no parent | no parent |
| not null | not null | add parent | add parent |
The proper condition should be:
null !== $resource->getId() && null === $resource->getParent()
Unless we want to change behavior?
tuka217
force-pushed
the
immutable-code-rbac
branch
from
4c8e12e
to
a52c472
Compare
…face [RbacBundle] Add AddParentFormSubscriber, add this and AddCodeFormSubscriber to builder in PermissionType and RoleType
tuka217
force-pushed
the
immutable-code-rbac
branch
from
a52c472
to
d3e1c54
Compare
pjedrzejewski
pushed a commit
that referenced
this pull request
Jan 5, 2016
[Rbac][RbacBundle] Introduce code for Rbac
|
Thanks Ania! 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.