Allow to add product with 0.00 price #374
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@pjedrzejewski Is it the good way ? |
| @@ -46,12 +46,6 @@ Feature: Product variants | |||
| When I press "Create" | |||
| Then I should see "Variant with this option set already exists." | |||
|
|
|||
| Scenario: Trying to create product variant with invalid price | |||
| Given I am creating variant of "Black T-Shirt" | |||
| When I fill in "Price" with "0.00" | |||
There was a problem hiding this comment.
Maybe replace "0.00" with string like "invalid price" or something similar to keep this scenario instead just removing it?
There was a problem hiding this comment.
It should not be removed definitely. Why not just checking if the price is not negative? So change the validation to minimum 0.00, and enter negative amount in the scenario.
|
Is is better ? |
|
Yeah! Let's wait for travis. :) |
|
Green 👍 |
pjedrzejewski
pushed a commit
that referenced
this pull request
Oct 4, 2013
Allow to add product with 0.00 price
|
Thank you Jeremy! |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
Mar 21, 2016
[Taxation] Update docs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.