[Shipment] Fix join on ShipmentRepository for Shipment Admin page #3779
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s admin page won't blow up if order doesn't have a shippingAddress
peteward
changed the title
pjedrzejewski
pushed a commit
that referenced
this pull request
Dec 27, 2015
[Shipment] Fix join on ShipmentRepository for Shipment Admin page
|
Makes sense, thanks Peter! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It could be specific to our app that shipments are created before addresses sometimes, but there's no point in this query being a left-join anyway since the
Backend/Shipment/macros.html.twigfile requires an address (and an order) for displaying shipments:https://github.com/Sylius/Sylius/blob/master/src/Sylius/Bundle/WebBundle/Resources/views/Backend/Shipment/macros.html.twig#L33