[Product] added original price #3783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
||
| public function isReduced() | ||
| { | ||
| if ($this->originalPrice > $this->price) { |
There was a problem hiding this comment.
return $this->originalPrice > $this->price;?
Missing doblock.
| <div class="product-box"> | ||
| <a href="{{ path(product) }}"><h4>{{ product.name|truncate(18) }}</h4></a> | ||
| <a href="{{ path(product) }}"> | ||
| <img class="img-rounded img-responsive" src="{{ product.image ? product.image.path|imagine_filter('sylius_medium') : 'http://placehold.it/262x255' }}" alt="{{ product.name }}" /> | ||
| <span class="label label-primary">{{ sylius_calculate_price(product.masterVariant)|sylius_price }}</span> | ||
| <!--<span class="label label-primary">{{ sylius_calculate_price(product.masterVariant)|sylius_price }}</span>--> |
| @@ -32,3 +32,10 @@ | |||
| </div> | |||
|
|
|||
| {% endmacro %} | |||
|
|
|||
| {% macro sylius_display_price_with_original(variant) %} | |||
There was a problem hiding this comment.
I would just call this sylius_display_price since the original is conditional
|
@pjedrzejewski @Zales0123 @lchrusciel @peteward I corrected everything you said. Anything more? |
pjedrzejewski
pushed a commit
that referenced
this pull request
Dec 30, 2015
[Product] added original price
|
Thank you Krzysztof! 👍 Nice work. :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of PR #3373