[Order] Implementation of OrderItemQuantityModifier #3795
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -15,6 +15,7 @@ | |||
| use Doctrine\Common\Collections\Collection; | |||
| use Sylius\Component\Cart\Model\Cart; | |||
| use Sylius\Component\Channel\Model\ChannelInterface as BaseChannelInterface; | |||
| use Sylius\Component\Inventory\Model\InventoryUnitInterface; | |||
pjedrzejewski
added
the
Enhancement
Zales0123
force-pushed
the
order-item-quantity-modifier
branch
2 times, most recently
from
a0e45d8
to
aa0949e
Compare
| } else if ($targetQuantity < $itemQuantity) { | ||
| $this->decreaseUnitsNumber($orderItem, $itemQuantity - $targetQuantity); | ||
| } | ||
|
|
There was a problem hiding this comment.
Redundant blank line
OrderItemUnit recalculations enhancements OrderItem recalculations enhancements Added get adjustments total recursively method Conflicts: src/Sylius/Component/Order/Model/OrderItem.php src/Sylius/Component/Order/spec/Model/OrderItemSpec.php
Also deleted unnecessary methods (setTotal and setItemsTotal in Order, setQuantity in OrderItem).
Zales0123
force-pushed
the
order-item-quantity-modifier
branch
from
46f951c
to
b8a65d0
Compare
| @@ -410,6 +410,7 @@ | |||
| <service id="sylius.promotion_action.add_product" class="%sylius.promotion_action.add_product.class%"> | |||
| <argument type="service" id="sylius.factory.order_item" /> | |||
| <argument type="service" id="sylius.repository.product_variant" /> | |||
| <argument type="service" id="sylius.modifier.order_item_quantity" /> | |||
There was a problem hiding this comment.
I think we should name it just sylius.order_item_quantity_modifier. Why? Because we should only group services, which really do the same thing. It is true for factory, repository, manager, controller etc. But Modifier in Sylius terms is very vague. We don't have any other modifiers and I doubt we will have anytime soon and if yes, then there is a low chance that they will be doing similar thing to this one. :) WDYT? /cc @michalmarcinkowski
There was a problem hiding this comment.
👍 I totally agree with this argumentation.
7 tasks
pjedrzejewski
pushed a commit
that referenced
this pull request
Jan 19, 2016
[Order] Implementation of OrderItemQuantityModifier
|
Thank you Mateusz! 👍 We are rocking this thing! ;) |
Closed
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
…ifier [Order] Implementation of OrderItemQuantityModifier
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
…ifier [Order] Implementation of OrderItemQuantityModifier
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
…ifier [Order] Implementation of OrderItemQuantityModifier
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
…ifier [Order] Implementation of OrderItemQuantityModifier
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is based on #3771 and correspond with @michalmarcinkowski work in #3786.
In this PR there is
OrderItemQuantityModifierimplemented, that handles item units management. The idea is, to changeOrderItemquantity only by adding/removing units.Possible improvements/modifications
UPDATE
I've applied commits from #3808, as they're necessary to make behat scenarios green.
UPDATE vol.2
Docs PR mentioned.