Fix .travis.yml and composer.json for individual bundles and components #3838
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
pjedrzejewski
changed the title
|
@Sylius/core-team Please review and merge if good to go, I'd like to run the subtree split manually and see how many builds are left to fix. :) |
|
|
||
| before_script: composer install --prefer-source --no-interaction | ||
| before_script: composer install --dev --prefer-source |
There was a problem hiding this comment.
We can remove --dev as it is the default behaviour.
There was a problem hiding this comment.
Why removing --no-interaction?
pjedrzejewski
force-pushed
the
fix-travis-ymls-and-composer-jsons
branch
from
9756c58
to
e6c6d6f
Compare
michalmarcinkowski
added a commit
that referenced
this pull request
Jan 9, 2016
…ser-jsons Fix .travis.yml and composer.json for individual bundles and components
|
👍 |
| @@ -26,10 +26,11 @@ | |||
| "doctrine/common": "~2.3", | |||
| "symfony/event-dispatcher": "^2.7", | |||
| "symfony/property-access": "^2.7", | |||
| "winzou/state-machine": "~0.1" | |||
| "winzou/state-machine": "~0.1", | |||
| "white-october/pagerfanta-bundle": "^1.0" | |||
There was a problem hiding this comment.
Why requiring the bundle instead of the component ?
Is it a hard dependency ?
There was a problem hiding this comment.
Good catch, probably wrong copy paste, I will check but I am 99% sure we don't need a bundle here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.