Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deps in most of bundles #3844

Conversation

pjedrzejewski
Copy link
Member

No description provided.

@@ -37,9 +38,11 @@
"require-dev": {
"phpspec/phpspec": "^2.4",
"akeneo/phpspec-skip-example-extension": "~1.2",
"doctrine/mongodb-odm": "1.0.*@dev",
"doctrine/mongodb-odm": "^1.0",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess it will fail because it requires ext-mongo which we don't have (at least on Travis).

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes and we don't have it on 7.0 yet I think, so we will need to live with a failing build anyway because excluding mongodb examples for 7.0 only is work that requires more time than I have right now. :P We can look at it shorlty after release I guess.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It will affect 5.5 and 5.6 too unless we add echo "extension = mongo.so" >> ~/.phpenv/versions/$(phpenv version-name)/etc/php.ini before installing dependencies.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can use mongofill https://github.com/mongofill/mongofill

- if [[ $TRAVIS_PHP_VERSION == '7.0' ]]; then composer require mongofill/mongofill=dev-master --no-update;

@pjedrzejewski pjedrzejewski force-pushed the fix-dependencies-of-individual-bundles branch from aad0da6 to 1db4efb Compare January 11, 2016 11:41
michalmarcinkowski added a commit that referenced this pull request Jan 11, 2016
…idual-bundles

Fix deps in most of bundles
@michalmarcinkowski michalmarcinkowski merged commit 34c9eda into Sylius:master Jan 11, 2016
@michalmarcinkowski
Copy link
Contributor

👍

@bendavies
Copy link
Contributor

resource bundle needs symfony/validator

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants