-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix deps in most of bundles #3844
Fix deps in most of bundles #3844
Conversation
@@ -37,9 +38,11 @@ | |||
"require-dev": { | |||
"phpspec/phpspec": "^2.4", | |||
"akeneo/phpspec-skip-example-extension": "~1.2", | |||
"doctrine/mongodb-odm": "1.0.*@dev", | |||
"doctrine/mongodb-odm": "^1.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I guess it will fail because it requires ext-mongo
which we don't have (at least on Travis).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes and we don't have it on 7.0 yet I think, so we will need to live with a failing build anyway because excluding mongodb examples for 7.0 only is work that requires more time than I have right now. :P We can look at it shorlty after release I guess.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It will affect 5.5 and 5.6 too unless we add echo "extension = mongo.so" >> ~/.phpenv/versions/$(phpenv version-name)/etc/php.ini
before installing dependencies.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
you can use mongofill https://github.com/mongofill/mongofill
- if [[ $TRAVIS_PHP_VERSION == '7.0' ]]; then composer require mongofill/mongofill=dev-master --no-update;
aad0da6
to
1db4efb
Compare
…idual-bundles Fix deps in most of bundles
👍 |
resource bundle needs |
No description provided.