[WIP] Add Subscription Bundle #385

Richtermeister · 2013-10-08T20:47:27Z

This goal of this PR is to add subscription features to Sylius, to support recurring orders, club-memberships, etc.

The model revolves around subscriptions and subscription items, which on the application level can be linked specific products/variants. The scheduling mechanism is decoupled so that complex scheduling scenarios can be supported. A simple interval-based scheduler is included. The bundle also comes with a command and a processor harness to process subscriptions that are due. Actual processing logic is delegated to the application layer.

I also added a new section to the customer panel to allow customers to manage their subscriptions.

Feedback pleez!
Thanks! :)

Todos:

Make Interval Units a dropdown and configurable
Add twig extension to format interval unit + frequency, i.e. "Every 10 days / Every Month"
Add Behat Features
Add ability to create new subscriptions (from cart / during checkout)
Add ability to add items to existing subscription (how to select product variant?)
Add admin capabilities
Add log / retry / audit capabilities (optional, could be separate bundle)

Richtermeister · 2013-10-08T20:53:48Z

Hi guys, thanks for checking this out. I hope this feature is in everybody's interest and not too opinionated.

I'm looking for feedback on whether this is the right approach, flexible enough, "Sylius worthy", etc.

With regards to the implementation, I'm not 100% sure about the Processor integration because it really only throws events, and I am also thinking about better interval handling which supports more flexible intervals. The current implementation works with only one unit (days), and it would be nice to support other intervals: First of every month, every Monday, each year on my Birthday.. so I'm wondering if the complex scheduling support should be delegated to a separate bundle which could also be used for other activities within Sylius (triggering emails, running batch operations, etc).

Thank you for feedback!

pjedrzejewski · 2013-10-08T22:51:36Z

I implemented similar system into client's Sylius app, but it could not be open sourced / extracted easily. I cried hard about that, but here you come and boom, awesome!

I hope to review this tomorrow. Sorry, today, it's 1AM here, snap...

Thanks Daniel, that look really great!

winzou · 2013-10-09T02:21:14Z

src/Sylius/Bundle/SubscriptionBundle/Command/ProcessSubscriptionsCommand.php

+    {
+        $output->writeln('Processing Subscriptions...');
+
+        $counter = new \stdClass();


Why not using a simple array?

You got it. Forgot about the "by reference" trick..

winzou · 2013-10-09T02:30:46Z

I had a very quick look, but awesome work so far!

stloyd · 2013-10-09T07:00:39Z

src/Sylius/Bundle/CoreBundle/Model/SubscriptionItem.php

+     */
+    public function getProduct()
+    {
+        return $this->variant->getProduct();


What if variant was not yet set?

Good point. I took inspiration from here: https://github.com/Sylius/Sylius/blob/master/src/Sylius/Bundle/CoreBundle/Model/OrderItem.php#L34 Guess we should fix it there as well.

Richtermeister · 2013-10-09T09:21:33Z

Hey guys, I just pushed a refactoring of the scheduling/processing code, and renamed a few interfaces/classes. (I took some inspiration from Magento).

This version should start to be pretty solid:

added Recurring/Schedulable interfaces so scheduling is more flexible and independent from entities
added lots more specs
recurring feature can be toggled with single configuration parameter

Also, thanks everybody for the feedback so far - I will make sure it will all be addressed.
Let me know if squashing the commits helps review this..

(todo list moved up top)

pjedrzejewski · 2013-10-09T09:57:27Z

@Richtermeister Please do not squash these commits, they're fine and reflect the dev process. Usually I prefer to squash some CS fix commits, simple typos or 5 commits changing 1 line. :)

amenophis · 2013-10-09T11:25:27Z

Oh i love this idea !!! 👍
I will use it as soon as it can be used :)

Richtermeister · 2013-10-09T18:58:43Z

@pjedrzejewski Thanks man, and thanks for the tweet! :)

Glad you like the idea, hope this implementation covers the features you had in your project.
Any other proprietary features you'd like opensourced? ;)

Richtermeister · 2013-10-09T19:04:02Z

@amenophis Thanks man. This should already be usable and I think it's starting to stabilize, you can give it a shot and let me know if it works for you or if you have unaddressed use-cases. Thanks! :)

stloyd · 2013-10-09T19:05:45Z

src/Sylius/Bundle/CoreBundle/Model/SubscriptionItem.php

+    {
+        if ($this->variant) {
+            return $this->variant->getProduct();
+        }


IMO you should do:

return null;

After that if just to have all things clear, and not guess.

pjedrzejewski · 2013-10-09T19:25:40Z

Would be nice to add some Behat scenarios for the account panel. Also, I think we want to create and list subscriptions in backend, but I'm in favor of adding this functionality after redesign PR which I hope to merge tonight / tomorrow in worst case... (I need to make the login page prettier and working) Thoughts?

Richtermeister · 2013-10-09T19:51:20Z

@stloyd Very good feedback man, can't sneak anything past you! ;) I hope I addressed it all. Thanks!

Richtermeister · 2013-10-09T19:56:54Z

@pjedrzejewski Absolutely! What I am not so sure about is how to select a product(variant) when adding a new subscription item, but I guess I can use the same form / resolving logic used in the front-end?

Also, great to hear about the Bootstrap3 update. I am currently running BS3 in the front-end and the global form-theming is messing with the admin area. I guess the demo site will have the reverse problem until the front-end is upgraded, too? Maybe forms should not be globally themed, only in the template where they are used? /offtopic

pjedrzejewski · 2013-10-09T20:03:08Z

Yeah, @stloyd's reviews are awesome, thanks for that man! :)

@Richtermeister I'll think about simplest way to select variant, we'll need the same thing for order creation... I think we should have a product selection autocomplete field, and then dynamically load options / variants selection fields. It can become complex, but I think we can do it in next iteration, it's cool as is. In my use case, subscriptions were created "in code", not via ui.

Regarding the B3 issue, I will take a look hard it will be to switch frontend to BS3, not changing the look, just updating the forms etc. I think I will be able to do it pretty easily so we avoid the conflicts.

Thanks for your work, I could give you a hand with Behat part, hm?

Richtermeister · 2013-10-09T20:59:21Z

@pjedrzejewski Re: Behat, if you're offering, I'm taking! Thanks! :) I'm sure I'll get another chance to learn it better..
Overall, are you happy with how this bundle is structured (all the interfaces, scheduler, processor, etc.., or should I rework anything?)

stloyd · 2013-10-10T07:24:42Z

src/Sylius/Bundle/CoreBundle/DataFixtures/ORM/LoadSubscriptionsData.php

@@ -0,0 +1,72 @@
+<?php
+
+namespace Sylius\Bundle\CoreBundle\DataFixtures\ORM;


Missing license header.

…ionItem and Subscription

…ome refactoring

… working

amenophis · 2014-11-04T16:29:46Z

Any chance to see this PR merged soon ?

pjedrzejewski · 2014-11-04T17:18:42Z

@amenophis I'd love to have that in core, but it requires review and this functionality is not a priority at this moment. I greatly appreciate all work done here and this will land in master, but can't estimate when... When we are done with current things. (search, api, new frontend/backend theme, multi-store)

MichaelMackus · 2014-11-04T19:09:44Z

@amenophis an alternative would be to use the 2 repos I linked to above... you should be able to add those to your composer.json and implement the necessary forms (from CoreBundle) in your application.. this is how we're doing it in one of our sites since they need this feature now

There's still things to be done, though... the payment processing & storage still needs to be implemented, for example. But I think this should be a good start, and the subscription frontend seems to be working well.

@pjedrzejewski if there's anything I can do to speed up the merge let me know

arnolanglade · 2014-11-04T19:17:38Z

@pjedrzejewski search, api, new frontend/backend theme, multi-store and the doc ;)

adremasu · 2015-01-22T12:48:38Z

any news about this issue?

drewmach · 2015-02-15T16:39:15Z

I just want to give a shout out that this is functionality I am looking for in Sylius as well. I will give a shot at trying to implement the repo's linked above and add the missing functionality, but would be awesome if this would be implemented in the core.

kzap · 2016-03-15T07:08:37Z

@pjedrzejewski
so subscriptions were never merged in?

is there any core component for this even?

or is subscriptions considered an archetype or a special pricing calculator on a product?

whats the easiest way one would extend the core to have subscriptions?

@MichaelMackus is this still being developed here or where should PR's be submitted?

MichaelMackus · 2016-03-15T16:02:07Z

@kzap development for this is being continued in the repos linked above.. the PR is on a hiatus until dev team is interested in merging

michalmarcinkowski · 2016-03-15T16:06:41Z

@MichaelMackus @kzap unfortunately this feature will not land on master in Sylius 1.0 release. We're in stabilization phase and as @pjedrzejewski comment here we have other more important features to polish. We will be interested to resume this work later on ;)

kzap · 2016-03-16T00:14:40Z

Thanks for keeping a updated repo..ill use yours then
On Mar 16, 2016 12:07 AM, "Michał Marcinkowski" notifications@github.com
wrote:

@MichaelMackus https://github.com/MichaelMackus @kzap
https://github.com/kzap unfortunately this feature will not land on
master in Sylius 1.0 release. We're in stabilization phase and as
@pjedrzejewski https://github.com/pjedrzejewski comment here
#385 (comment) we have
other more important features to polish. We will be interested to resume
this work later on ;)

—
You are receiving this because you were mentioned.
Reply to this email directly or view it on GitHub:
#385 (comment)

[Rbac] Update documentation

xrow · 2017-11-23T01:05:11Z

Hi, I have an requirement on this feature. The last update is already long ago. I am wondering, if one can provide an update on the roadmap / timings. So far is looks like that this will never get merged since it is so old. Please don't mind asking. I am just curious. Thx.

lchrusciel · 2017-11-28T07:40:52Z

I'm not sure if there is any point in keeping this one open. Too many things have changed. Thus it is a good plugin proposal :)

gadelkareem · 2019-12-30T14:55:05Z

hmm, any plugin already available providing this feature?

winzou reviewed Oct 9, 2013
View reviewed changes

stloyd reviewed Oct 9, 2013
View reviewed changes

stloyd reviewed Oct 10, 2013
View reviewed changes

MichaelMackus added 6 commits November 3, 2014 15:31

Allow adding subscription from cart item form, and combined Subscript…

b181c51

…ionItem and Subscription

Subscription cart form frontend/UI

d2cb9dc

Changed subscription interval to DateInterval object, frontend, and s…

0b01503

…ome refactoring

License headers & minor cs

6e92cba

Refactored code to use SimpleRecurringSubscriptionType and validators…

26cb31a

… working

cs and misc fixes

f93129b

MichaelMackus force-pushed the subscription-bundle branch from e5a5194 to f93129b Compare November 3, 2014 23:32

pjedrzejewski removed this from the v1.0.0-ALPHA1 milestone May 11, 2015

pjedrzejewski added New Feature and removed Enhancement Minor issues and PRs improving the current solutions (optimizations, typo fixes, etc.). labels Dec 14, 2015

pamil pushed a commit to pamil/Sylius that referenced this pull request Mar 21, 2016

Merge pull request Sylius#385 from tuka217/immutable-code-rbac

a369c97

[Rbac] Update documentation

pamil added Feature New feature proposals. and removed Feature New feature proposals. Future labels Oct 26, 2017

lchrusciel closed this Nov 28, 2017

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[WIP] Add Subscription Bundle #385

[WIP] Add Subscription Bundle #385

Richtermeister commented Oct 8, 2013

Richtermeister commented Oct 8, 2013

pjedrzejewski commented Oct 8, 2013

winzou Oct 9, 2013

Richtermeister Oct 9, 2013

winzou commented Oct 9, 2013

stloyd Oct 9, 2013

Richtermeister Oct 9, 2013

Richtermeister commented Oct 9, 2013

pjedrzejewski commented Oct 9, 2013

amenophis commented Oct 9, 2013

Richtermeister commented Oct 9, 2013

Richtermeister commented Oct 9, 2013

stloyd Oct 9, 2013

pjedrzejewski commented Oct 9, 2013

Richtermeister commented Oct 9, 2013

Richtermeister commented Oct 9, 2013

pjedrzejewski commented Oct 9, 2013

Richtermeister commented Oct 9, 2013

stloyd Oct 10, 2013

amenophis commented Nov 4, 2014

pjedrzejewski commented Nov 4, 2014

MichaelMackus commented Nov 4, 2014

arnolanglade commented Nov 4, 2014

adremasu commented Jan 22, 2015

drewmach commented Feb 15, 2015

kzap commented Mar 15, 2016

MichaelMackus commented Mar 15, 2016

michalmarcinkowski commented Mar 15, 2016

kzap commented Mar 16, 2016

xrow commented Nov 23, 2017

lchrusciel commented Nov 28, 2017

gadelkareem commented Dec 30, 2019

		@@ -0,0 +1,72 @@
		<?php

		namespace Sylius\Bundle\CoreBundle\DataFixtures\ORM;

[WIP] Add Subscription Bundle #385

[WIP] Add Subscription Bundle #385

Conversation

Richtermeister commented Oct 8, 2013

Richtermeister commented Oct 8, 2013

pjedrzejewski commented Oct 8, 2013

winzou Oct 9, 2013

Choose a reason for hiding this comment

Richtermeister Oct 9, 2013

Choose a reason for hiding this comment

winzou commented Oct 9, 2013

stloyd Oct 9, 2013

Choose a reason for hiding this comment

Richtermeister Oct 9, 2013

Choose a reason for hiding this comment

Richtermeister commented Oct 9, 2013

pjedrzejewski commented Oct 9, 2013

amenophis commented Oct 9, 2013

Richtermeister commented Oct 9, 2013

Richtermeister commented Oct 9, 2013

stloyd Oct 9, 2013

Choose a reason for hiding this comment

pjedrzejewski commented Oct 9, 2013

Richtermeister commented Oct 9, 2013

Richtermeister commented Oct 9, 2013

pjedrzejewski commented Oct 9, 2013

Richtermeister commented Oct 9, 2013

stloyd Oct 10, 2013

Choose a reason for hiding this comment

amenophis commented Nov 4, 2014

pjedrzejewski commented Nov 4, 2014

MichaelMackus commented Nov 4, 2014

arnolanglade commented Nov 4, 2014

adremasu commented Jan 22, 2015

drewmach commented Feb 15, 2015

kzap commented Mar 15, 2016

MichaelMackus commented Mar 15, 2016

michalmarcinkowski commented Mar 15, 2016

kzap commented Mar 16, 2016

xrow commented Nov 23, 2017

lchrusciel commented Nov 28, 2017

gadelkareem commented Dec 30, 2019