Repository clean up and TranslatableResourceRepository deletion #3854
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lchrusciel
changed the title
lchrusciel
changed the title
lchrusciel
changed the title
michalmarcinkowski
added
Bug Fix
BC Break
lchrusciel
force-pushed
the
repository-xmass-cleaning
branch
from
32d9e32
to
f2bcb33
Compare
|
|
||
| namespace Sylius\Component\Addressing\Repository; | ||
|
|
||
| use Doctrine\ORM\NonUniqueResultException; |
There was a problem hiding this comment.
This definitely cannot be in component.
lchrusciel
force-pushed
the
repository-xmass-cleaning
branch
7 times, most recently
from
8c16ae0
to
b10a0df
Compare
lchrusciel
changed the title
| { | ||
| return $this->createQueryBuilder('o') | ||
| ->where('o.name = :name') | ||
| ->setParameter('name', $name) |
There was a problem hiding this comment.
The name is not translatable and we don't need to join anything, so I think this method is redundant and we should use simply findOneBy(array('name' => $name)).
There was a problem hiding this comment.
We should join zone members here.
lchrusciel
force-pushed
the
repository-xmass-cleaning
branch
4 times, most recently
from
48a5df5
to
25c7d1b
Compare
| @@ -32,8 +39,13 @@ public function findRootNodes(); | |||
| * @param string $permalink | |||
| * | |||
| * @return TaxonInterface | |||
lchrusciel
force-pushed
the
repository-xmass-cleaning
branch
from
7991bc3
to
e564680
Compare
lchrusciel
force-pushed
the
repository-xmass-cleaning
branch
from
5796164
to
8a44742
Compare
lchrusciel
force-pushed
the
repository-xmass-cleaning
branch
from
8a44742
to
46c6f64
Compare
|
@pjedrzejewski Build should be green, so it is good to merge. But we have to resolve #4410 as soon as possible. |
pjedrzejewski
pushed a commit
that referenced
this pull request
Mar 7, 2016
Repository clean up and TranslatableResourceRepository deletion
|
Good work Łukasz! I am glad we have this cleaned up finally... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've made some clean ups in repositories and introduced some new repository interfaces. Moreover, I have also removed TranslatableResourceRepository and translation fields from configuration. It will reduce amount of magic in our repositories and will result in explicit calls to them. I am aware that this is a huge BC break, but it is better to do such changes earlier than later ;)
Update
NOTE: In order to be as explicit as it is possible, I removed all magic methods and functions like getQueryBuilder. Repositories will be much more readable if we will call methods directly, where one has to declare every used join. Previous implementation was hard to maintain as some times we used some objects joined in a parent class of parent class of parent class of the class we used. This was misleading and generated enormous amount of bugs. I removed some spec also, cuz implementation of repository has been changed and it's logic is tested anyway in a behat scenarios.
Uodate2
NOTE: Contains changes from #4271