[Order] Change Adjustment description to label #3880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Zales0123
commented
Jan 14, 2016
Zales0123
commented
| Q | A |
|---|---|
| Bug fix? | no |
| New feature? | no |
| BC breaks? | yes |
| Deprecations? | no |
| Fixed tickets | #3849 |
| License | MIT |
| Doc PR | Sylius/Sylius-Docs#396 |
pjedrzejewski
added
the
DX
Zales0123
force-pushed
the
adjustment-description-to-label
branch
from
05e4393
to
5cadc89
Compare
|
|
||
| $order->addAdjustment($adjustment); | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
Should be reverted.
Zales0123
force-pushed
the
adjustment-description-to-label
branch
from
5cadc89
to
333ecd0
Compare
michalmarcinkowski
added
BC Break
|
👍 |
1 similar comment
|
👍 |
Zales0123
force-pushed
the
adjustment-description-to-label
branch
from
333ecd0
to
e63124a
Compare
|
@pjedrzejewski @michalmarcinkowski same here, Scrutinizer error :( |
|
@Zales0123 Please update UPGRADE file. |
|
@pjedrzejewski done 👍 |
Zales0123
force-pushed
the
adjustment-description-to-label
branch
from
890bce5
to
acb3f60
Compare
Zales0123
force-pushed
the
adjustment-description-to-label
branch
from
8b8028e
to
1fb0643
Compare
| { | ||
| /** @var $promotion PromotionInterface */ | ||
| $promotion = $this->getPromotionFactory()->createNew(); | ||
| $promotion->setName($name); | ||
| $promotion->setDescription($description); | ||
| $promotion->setDescription($label); |
Zales0123
force-pushed
the
adjustment-description-to-label
branch
from
1fb0643
to
0ec405d
Compare
pjedrzejewski
pushed a commit
that referenced
this pull request
Jan 26, 2016
[Order] Change Adjustment description to label
|
Thanks Mateusz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.