[Currency] Add isBase flag on CurrencyInterface #3887
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Somehow I find |
|
@pamil @TheMadeleine DefaultableInterface :D |
| @@ -23,6 +23,7 @@ | |||
| <field fieldName="code" name="code" type="string" length="3" /> | |||
| <field fieldName="exchangeRate" name="exchangeRate" type="float" /> | |||
| <field fieldName="enabled" name="enabled" type="boolean" /> | |||
| <field name="isBase" column="is-base" type="boolean" /> | |||
There was a problem hiding this comment.
Hmmm, every other column is called in camelCase, why changing approach for this one?
CoderMaggie
force-pushed
the
is-base-on-currency-interface
branch
from
bf9a37f
to
5643e94
Compare
pjedrzejewski
pushed a commit
that referenced
this pull request
Jan 15, 2016
[Currency] Add isBase flag on CurrencyInterface
|
Thanks Magda! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added all methods required to set a Currency as a base one. This PR is connected with #3814, because now during the installation we get only one currency from the user, and we want to set it as the base one.