[WebBundle] Translations cleanup #3908
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
pamil
commented
Jan 18, 2016
pamil
commented
- Translations ordered alphabetically
- Removed punctuations marks at the end of translation
- Every translation starts with a capital letter
pamil
force-pushed
the
translation-values-webbandl
branch
2 times, most recently
from
6edec90
to
a1bb459
Compare
pamil
force-pushed
the
translation-values-webbandl
branch
from
a1bb459
to
82cb41d
Compare
| @@ -400,6 +400,7 @@ default: | |||
| extensions: | |||
| Lakion\Behat\MinkDebugExtension: | |||
| directory: etc/build | |||
| clean_start: false | |||
There was a problem hiding this comment.
I've smuggled a tiny change here to make logs of failing scenarios available (as MinkDebugExtension.clean_start=true by default and it was clearing the etc/build/ directory).
pjedrzejewski
pushed a commit
that referenced
this pull request
Jan 18, 2016
[WebBundle] Translations cleanup
|
Thanks Kamil! 👍 Also, thanks for smuggling changes explicitly! |
pamil
pushed a commit
to pamil/Sylius
that referenced
this pull request
May 7, 2019
[WebBundle] Translations cleanup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.