[Attribute] Fixed some minor issues with attributes #3921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- changed ``dateTime`` field to ``datetime`` - removed weird ``oldhref`` from attribute choice element - removed broken ``__toString()`` from ``AttributeValue``
| @@ -10,9 +10,9 @@ | |||
| <div class="list-group row"> | |||
There was a problem hiding this comment.
Hi @Zales0123,
I'm just updating our backend for an entity to use this attribute UI - looking good!
The only issue I'm having is that this line here is coupled to ProductAttributes (and I need to use it for a different model), as you can see from the routing:
sylius_backend_render_attribute_forms:
path: /attribute-forms
methods: [GET]
defaults:
_controller: sylius.controller.product_attribute:renderAttributeValueFormsAction
Is this something that you can look at?
There was a problem hiding this comment.
Good catch, I think we have one more coupling issue in the CompilerPass. It assumes there is product_attribute service and that's incorrect.
There was a problem hiding this comment.
Sure, these are things that have to be fixed 👍 I'm sure I can handle these issues in the nearest future.
pjedrzejewski
pushed a commit
that referenced
this pull request
Jan 20, 2016
[Attribute] Fixed some minor issues with attributes
|
Thanks Mateusz! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
dateTimefield todatetimeoldhreffrom attribute choice element__toString()fromAttributeValue