[ResourceBundle] Generic autocomplete form type for resources

[tuka217]

Q	A
Bug fix?	no
New feature?	yes
BC breaks?	no
Deprecations?	no
Fixed tickets	#3831
License	MIT
Doc PR	-

[Zales0123]

All arrays should be changed to [...] ;)

[michalmarcinkowski]

Same as above.

[lchrusciel]

I'm not sure about this transformer. I bet it could cause a weird bugs or blow up a whole app if another similar transformer would be placed somewhere else...

[pjedrzejewski]

Great work Ania! Thank you! 🎆 👍

[bendavies]

so when are ResourceToIdentifierTransformer and ResourceFromIdentifierTransformer used?

[pjedrzejewski]

ResourceToIdentifier is used when we need to select a resource from list, but the end data should be identifier: for example on promotions, where we need to select a taxon, but in db we want to serialize only its code, not whole object.

ResourceFromIdentifier is used when we want to use a hidden field with taxon code in the frontend (for autocomplete), but need real object to be the end data. (mainTaxon select field on Product)

[bendavies]

thanks @pjedrzejewski

[koemeet]

@pjedrzejewski Isn't it a better idea to use the doctrine types for this and add it on pre_submit, so you have the "hidden" effect, but still keep a proper choice list to work with your data. I think it is quite limiting to use those types for handling auto complete etc. Also the EntityType will use the provided query builder with an appended AND WHERE id = :submitted_id, so your DB queries are fine there. If we would not use that approach, how could we for example use it for "hidden" multiple choice fields?

// would something like this be acceptable? It is easy to understand and hides it from rendering in the front-end, so no 100.000 variant lookups.
$builder->addEventListener(FormEvents::PRE_SUBMIT, function(FormEvent $event) {
    $event->getForm()->add('variant', 'sylius_product_variant_choice');
});